diff options
author | Julia Lawall <julia@diku.dk> | 2010-08-11 18:20:55 +0200 |
---|---|---|
committer | Jean Delvare <khali@linux-fr.org> | 2010-08-11 18:20:55 +0200 |
commit | f1c2e33c295de423db5740647bfaa5e2ad139192 (patch) | |
tree | 82d2d788d711d012a816dbab4d62fb5bcd2a8e87 /sound/i2c/i2c.c | |
parent | 35a56c5b821c1a5ab904018f322a8e45afd116f0 (diff) |
i2c-dev: Use memdup_user
Use memdup_user when user data is immediately copied into the allocated
region. Note that in the second case, the ++i is no longer necessary, as
the last value is already freed if needed by the call to memdup_user.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression from,to,size,flag;
position p;
identifier l1,l2;
@@
- to = \(kmalloc@p\|kzalloc@p\)(size,flag);
+ to = memdup_user(from,size);
if (
- to==NULL
+ IS_ERR(to)
|| ...) {
<+... when != goto l1;
- -ENOMEM
+ PTR_ERR(to)
...+>
}
- if (copy_from_user(to, from, size) != 0) {
- <+... when != goto l2;
- -EFAULT
- ...+>
- }
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Diffstat (limited to 'sound/i2c/i2c.c')
0 files changed, 0 insertions, 0 deletions