summaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2013-05-30staging: xgifb: SetFlag: delete DisableChBAaro Koskinen
This flag is never set, so checks can be removed and code behind it deleted. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: xgifb: SetFlag: delete GatingCRTAaro Koskinen
This flag is never set, so checks can be removed and code behind it deleted. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: xgifb: XGI_SetCRT1VCLK(): avoid copy-pasteAaro Koskinen
Avoid copy-pasted code in if branches by rearranging the checks. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: xgifb: XGI_GetRatePtrCRT2(): delete IF_DEF_LVDS checkAaro Koskinen
IF_DEF_LVDS cannot be set if ProgrammingCRT2 flag is set, so remove the check to simplify the code. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: xgifb: XGI_AjustCRT2Rate(): delete IF_DEF_LVDS checkAaro Koskinen
IF_DEF_LVDS cannot be set when XGI_AjustCRT2Rate() is called, so we can remove the check and dead code. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: xgifb: call XGI_GetVBType from InitTo330PointerAaro Koskinen
Move XGI_GetVBType call inside InitTo330Pointer to avoid code duplication. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: xgifb: XGI_GetVBType(): delete IF_DEF_LVDS checkAaro Koskinen
XGI_GetVBType() is called only for chips < XG20 so IF_DEF_LVDS cannot be set. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: xgifb: refactor XGI_BridgeIsOn()Aaro Koskinen
Refactor XGI_BridgeIsOn(). IF_DEF_LVDS bit is not valid for < XG20 chips. Also we can make the function static by moving it to vb_init. Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging/lustre: fix LBUG and inode refcount bugPeng Tao
ldlm_proc_setup and ldlm_proc_cleanup should reset global pde pointers otherwise remount may hit LASSERT(ldlm_ns_proc_dir == NULL); Also in libcfs_sock_ioctl, fput() includes itself sock_release. So don't call sock_release twice otherwise kernel may oops due to incorrect inode ref counting. Signed-off-by: Peng Tao <tao.peng@emc.com> Signed-off-by: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging/lustre: adapt proc_dir_entry changePeng Tao
In 3.10 merge window, proc_dir_entry is now private to proc. However, Lustre lprocfs depends heavily on it and its now-gone read_proc_t and write_proc_t members. The patch largely changed the fact, and made lprocfs depend on none of proc_dir_entry private members. All lprocfs callers are converted to use the new seq_file scheme. Also lprocfs_srch is removed so that we can drop lprocfs_lock. All callers are changed to save created pde in proper place. See https://jira.hpdd.intel.com/browse/LU-3319 for more details. Signed-off-by: Peng Tao <tao.peng@emc.com> Signed-off-by: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging/lustre: fix build errorPeng Tao
We missed one file... Signed-off-by: Peng Tao <tao.peng@emc.com> Signed-off-by: Andreas Dilger <andreas.dilger@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30Staging: rtl8192e: fix an endian bugDan Carpenter
Passing the high bits of "ratr_value" to rtl8192_config_rate() only works on little endian systems. We should be passing a u16 value. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30Staging: rtl8192e: printing the wrong arrayDan Carpenter
Smatch complained that there is an array overflow here. It looks like we are supposed to be printing the ->rates_ex[] array which is slightly larger than the ->rates[] array. This is a cut and paste error. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30Staging: rtl8192e: delete some dead cruftDan Carpenter
I have removed some unneeded comments, some blank lines and some unused macros. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30Staging: vt6655: add missing free_netdev() on error in hostap_enable_hostapd()Wei Yongjun
Add the missing free_netdev() before return from function hostap_enable_hostapd() in the error handling case. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: keucr: remove needless check before usb_free_coherent()Wei Yongjun
usb_free_coherent() is safe with NULL addr and this check is not required. Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up the multi-line commentsH Hartley Sweeten
Modify the multi-line comments to follow the CodingStyle. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: remove a space before tabH Hartley Sweeten
checkpatch.pl reports: WARNING: please, no space before tabs +^Ihigh_speed = 0; ^I/* (devpriv->high_speed) */$ Remove the space to avoid the warning. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up chanToInterval()H Hartley Sweeten
Rename the function to have namespace associated with the driver. Rename the CamelCase parameter 'nChannels' to avoid the checkpatch.pl warning. Tidy up the function a bit. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: add missing spaces reported by checkpatch.plH Hartley Sweeten
checkpatch.pl reports: ERROR: space required after that ',' (ctx:VxV) + dev_dbg(dev->class_dev,"CRC error in ISO IN stream\n"); ^ ERROR: spaces required around that '=' (ctx:VxW) + struct usbduxsigma_private *devpriv= dev->private; ^ Add the missing spaces to avoid the error. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: rename CamelCase vars in private dataH Hartley Sweeten
Rename the CamelCase variables in the private data to avoid the checkpatch.pl warning. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: remove some unused definesH Hartley Sweeten
These defines are not used in the driver. Remove them. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up the usb endpoint definesH Hartley Sweeten
Rename the defines so they have namespace associated with the driver. Tidy up the defines. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: cleanup comedi_lrange tableH Hartley Sweeten
Rename the table so it has namespace associated with the driver. Tidy up the whitespace of the table. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: rename usbdux_{ai,ao}_stop() functionsH Hartley Sweeten
Rename the functions so they have namespace associated with the driver. For aesthetic reasons, pass the comedi_device pointer instead of the private data pointer as the first parameter. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: rename the (*cancel) functionsH Hartley Sweeten
Rename these functions so they have namespace associated with the driver. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: rename the urb completion handlersH Hartley Sweeten
Rename these functions so they have namespace associated with the driver and their use is aparent. Also, rename the #defines used for the bulk transfer commands and move them up with the other defines. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: rename {send,receive}_dux_commands()H Hartley Sweeten
Rename these functions so they have namespace associated with the driver. Also, rename the #defines used for the bulk transfer commands and move them up with the other defines. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: check for invalid 'ao_timer' in all casesH Hartley Sweeten
Make sure to check that the 'ao_timer' value is valid for both the high speed and low speed cases in usbduxsigma_ao_cmdtest(). Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up analog input command supportH Hartley Sweeten
Rename the (*do_cmdtest) and (*do_cmd) functions so they have namespace associated with the driver. Rename the local variable used for the private data pointer. Move all the command argument initialization and testing into the (*do_cmdtest) function. That function is always called by the comedi core before the (*do_cmd) function. The only thing the (*do_cmd) function should have to do is setup the channel list, send the command to start the analog input sampling, initialize the counter for the conversion, then either read the acquisition data (submit the urbs) or set the trigger to read the data later. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up usbdux_ai_insn_read()H Hartley Sweeten
Rename the function so it has namespace associated with the driver. Rename the local variable used for the private data pointer. Return -EBUSY if an asynchronous command is running and the read cannot be completed. Propagate the errno if the receive_dux_command() fails. Tidy up the function to make it more concise. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: cleanup the private data 'outBuffer'H Hartley Sweeten
This buffer is used to cache the analog output values that are written to the analog output channels. Currently it only caches the single writes to the channels using the (*insn_write) callback. The async command writes are not cached. The buffer is also being kzalloc'ed during the attach of the driver to a size much larger that required. Rename the CamelCase buffer and change it to an array in the private data of the correct size to cache the analog output channel values. Modify the analog output urb callback so it updates the cached values with those used for the asynchronous command to allow readback after the command completes. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up analog output (*insn_{read, write})H Hartley Sweeten
Rename the functions so they have namespace associated with the driver. Rename the local variable used for the private data pointer. Return -EBUSY from the (*insn_write) function if an asynchronous command is running that the write cannot be completed. Don't save the cached value of the analog output for readback unless the command to set it is successful. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up analog output command supportH Hartley Sweeten
Rename the (*do_cmdtest) and (*do_cmd) functions so they have namespace associated with the driver. Rename the local variable used for the private data pointer. Move all the command argument initialization and testing into the (*do_cmdtest) function. That function is always called by the comedi core before the (*do_cmd) function. The only thing the (*do_cmd) function should have to do is setup the channel list, initialize the counter for the conversion, then either start the conversion (submit the urbs) or set the trigger to start the conversion. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: rename usbdux_pwm_stop()H Hartley Sweeten
Rename the function so it has namespace associated with the driver. For aesthetic reasons, pass the comedi_device pointer instead of the private data pointer as the first parameter. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: rename usbdux_pwm_cancel()H Hartley Sweeten
Rename the function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: rename usbdux_pwm_irq()H Hartley Sweeten
Rename the function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up usbdux_pwm_period()H Hartley Sweeten
Rename the function so it has namespace associated with the driver. Rename the local variable used for the private data pointer. Modify the fx2delay calculation to remove the floating point values. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: change private data flags to bit fieldsH Hartley Sweeten
Change the type of all the true/false flags in the private data to bit fields. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: remove 'interface' from the private dataH Hartley Sweeten
This back pointer to the usb_interface is not used, remove it. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: remove some dev_{level} noiseH Hartley Sweeten
Remove the dev_err() and dev_dbg() messages that are just kernel noise. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up usbdux_dio_insn_config()H Hartley Sweeten
Rename the function so it has namespace associated with the driver. Rename the local variable used for the private data pointer. Add a local variable for the channel mask. Remove the unnecessary comments and clean up the multi-line comment at the end. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up usbdux_dio_insn_bits()H Hartley Sweeten
Rename the function so it has namespace associated with the driver. Rename the local variable used for the private data pointer. Remove the unnecessary casts. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up usbdux_pwm_start()H Hartley Sweeten
Rename the function so it has namespace associated with the driver. Rename the local variable used for the private data pointer. Remove the unnecessary cast of the pwm delay. Use memset to initialize the buffer instead of the for loop. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up usbdux_pwm_pattern()H Hartley Sweeten
Rename the function so it has namespace associated with the driver. Tidy up the function to make it more concise. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up usbdux_pwm_write()H Hartley Sweeten
Rename the function so it has namespace associated with the driver. Tidy up the comments. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: remove usbdux_pwm_read()H Hartley Sweeten
The comment says its not needed, just remove it. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: tidy up usbduxsigma_pwm_config()H Hartley Sweeten
Rename the function so it has namespace associated with the driver. Rename the local variable used for the private data pointer. Remove some unnecessary comments and tidy up the comment about the parameters for the INSN_CONFIG_PWM_SET_H_BRIDGE instruction. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: move usbduxsigma_firmware_upload()H Hartley Sweeten
For aesthetics, move this function near its caller. Also, move the FIRMWARE_MAX_LEN define so its with the other firmware constants and fix the whitespace. Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-05-30staging: comedi: usbduxsigma: remove an extra ';'H Hartley Sweeten
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2024-10-20 12:54:54 +0000