summaryrefslogtreecommitdiffstats
path: root/drivers/staging/bcm
AgeCommit message (Collapse)Author
2010-12-06Staging: Beceem: more checkpatch.pl changes to InterfaceInit.cDan Carpenter
The only checkpatch.pl issues remaining still remaining are line length complaints. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-06Staging: Beceem: improve debug printk statementsDan Carpenter
These are just small changes. Some grammar and wording changes. I added new lines to the end of all the print statements. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-06Staging: Beceem: use after free in bcm_exit()Dan Carpenter
We can't call class_destroy() until after the driver has been deregistered. It leads to a NULL deref on module unload. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-06Staging: Beceem: remove old kernel compatibility codeDan Carpenter
This drops compatability for everything from 2.4 to 2.6.35. Now it only works on the latest kernel. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-06Staging: Beceem: white space changes to InterfaceInit.cDan Carpenter
This patch only changes: 1) spaces, tabs, and newline characters. 2) comment styles. The compiled object file is the same before and after except for line number changes. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-06Staging: Beceem: use lower case "int" instead of "INT"Dan Carpenter
This patch changes: INT => int ULONG => unsigned long VOID => void Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-06Staging: Beceem: add USB id for BCSM250 Mobile WiMAXDan Carpenter
Signed-off-by: Dan Carpenter <error27@gmail.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-11-16Staging: bcm: signedness bug in InitCardAndDownloadFirmware()Dan Carpenter
status is used to store negative error codes throughout. The only place where this is a runtime bug is if create_worker_threads() fails. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-11-16Staging: bcm: signedness bug in StoreSFParam()Dan Carpenter
wrm() returns negative error codes so "ret" needs to be signed here. There was place where wrm() returned positive EACCES instead of negative -EACCES so I fixed that as well. Also a few checkpatch.pl issues. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-11-16drivers/staging: Remove unnecessary semicolonsJoe Perches
Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-11-16Staging: Merge 2.6.37-rc2 into staging-nextGreg Kroah-Hartman
This was necessary in order to resolve some conflicts that happened between -rc1 and -rc2 with the following files: drivers/staging/bcm/Bcmchar.c drivers/staging/intel_sst/intel_sst_app_interface.c All should be resolved now. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-11-10Staging, bcm: Remove unnecessary casts of void ptr returning alloc function ↵Jesper Juhl
return values Here's a patch against a copy of linux-next that I just cloned. Don't pointlessly cast pointers returned by allocation functions that return void pointers which are implicitly converted. For drivers/staging/bcm/ Signed-off-by: Jesper Juhl <jj@chaosbits.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-11-10Staging: beceem: Move ZTE TU25's USB id to the beceem moduleAlejandro R. Sedeño
Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-11-10Staging: beceem: Use 32-bit integers for hardware register valuesAlejandro R. Sedeño
Switching to UINT because that's what the rest of this codebase uses. Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-11-09Staging: bcm: use get_user() to access user pointersDan Carpenter
This fixes some places that dereference user pointers directly instead of using get_user(). Please especially check my changes to IOCTL_BCM_GET_CURRENT_STATUS. The original code modified the struct which "arg" was pointing to. I think this was a bug in the original code and that we only wanted to write to the OutputBuffer. Also with the original code you could read as much memory as you wanted so I had to put a cap on OutputLength. The only value of OutputLength that makes sense is sizeof(LINK_STATE) so now if OutputLength is not sizeof(LINK_STATE) it returns -EINVAL. Signed-off-by: Dan Carpenter <error27@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-11-01beceem: update TODO listStephen Hemminger
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: dump control packet informationStephen Hemminger
Add control packet information is useful for debugging. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: change startup messagesStephen Hemminger
Change the regsister/unregister routines to generate better messages, and control arrival of new frames when USB device is unplugged. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: don't overrun user buffer on readStephen Hemminger
Serious bug in original code, if app reads 10 bytes but 20 byte msg received memory would get overwritten. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: eliminate unused bcm_jiffiesStephen Hemminger
Unused, unneeded, and bogus. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: fix definition of VLAN header typeStephen Hemminger
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: statistics and transmit queue changesStephen Hemminger
Use standard network statistics variables and routines. Transmit counters are per queue, and skb mapping is already in skb and does not need to be recomputed. Move SearchVcId to only place it is used. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: do classification even if device is offlineStephen Hemminger
Since classification and queue control are separate, allow classification even if device is down now; this avoids races on startup/shutdown. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: off by one on queue indexStephen Hemminger
The driver allocates 18 queues (0..16) are for traffic, and 17 is a bit bucket. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: make local functions staticStephen Hemminger
Use namespace tool from kernel scripts to identify dead code and functions that should be static. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: remove unused code to dump headerStephen Hemminger
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: transmit code cleanupStephen Hemminger
Eliminate global variable in transmit path The Leader can be on the stack, and get rid of unnecessary timeval. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: allow multicast/broadcastStephen Hemminger
Even though wimax isn't really a broadcast medium, pretend it is. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: debug message format changesStephen Hemminger
Add more debug messages and make them similar to other drivers Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: use get_seconds for elapsed timeStephen Hemminger
get_seconds is lower overhead and fine if all driver wants to do is keep track of seconds. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: module initializationStephen Hemminger
Get rid of boot messages and put in correct place. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: add network device message level controlStephen Hemminger
Provide standard interface to control verbosity of debug messages Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: change format of debug messageStephen Hemminger
Statistic point is now u32 (like it has to be). Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: clean up adapter structureStephen Hemminger
Remove dead fields, change fields that only have true/false to boolean; and rearrange to save space. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: create class on module installationStephen Hemminger
First step to supporting multiple devices, create device class when module is initialized. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: convert to kernel coding styleStephen Hemminger
Change indentation etc, to conform to acceptable kernel style Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: remove useless debug function entry messagesStephen Hemminger
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: remove problematic debug print messagesStephen Hemminger
Not worth bothering to change printf format of messages which are basically noise. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: remove unnecessary usb classStephen Hemminger
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: fix character device ioctlStephen Hemminger
Sparse caught several places where ioctl interface was incorrectly using user memory. Fix all the ioctl cases for casting and __user annotation. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: fix printf format stringsStephen Hemminger
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: reserve one queue for bit-bucketStephen Hemminger
This preserves the semantics of the original driver (unclassified packets are dropped), but does it in a clean way; and fixes crash when packet is sent to offline device. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: remove dead codeStephen Hemminger
Remove commented out with '#if 0' Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: support multiple queuesStephen Hemminger
Current kernels have multi-queue support which can be used by this device. This has the advantage that a single type of traffic will not block other types. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: get rid of unnecessary inline usageStephen Hemminger
Many routines were tagged with inline_ but GCC does a better job of deciding this. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: fold unregister_netdevice into AdapterFreeStephen Hemminger
The function unregister_netdevice only called unregister_netdev. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: remove ARP spoofingStephen Hemminger
Linux support NOARP flag, so the whole Arp spoofing routines are not needed. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: print better message on bad ioctlStephen Hemminger
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
2010-11-01beceem: remove indirection to Adapter structureStephen Hemminger
Allocate Adapter structure as part of network device. Signed-off-by: Stephen Hemminber <shemminger@vyatta.com>
2010-11-01beceem: Add proper carrier and link managementStephen Hemminger
Start with carrier off. Don't track up/down status in driver private flag. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>