summaryrefslogtreecommitdiffstats
path: root/drivers/staging/rtl8192u
AgeCommit message (Collapse)Author
2014-06-26staging: rtl8192u: r8192U_core.c: Cleaning up variable is set more than onceRickard Strandqvist
A struct member variable is set to the same value more than once This was found using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26Staging: rtl8192u: r8192U_wx.c Fixed a code-style error about trailing ↵Chaitanya Hazarey
whitespace Fixed the following error reported by running checkpatch.pl ERROR: trailing whitespace Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26Staging: rtl8192u: r8192U_wx.c Fixed some more code-style warnings about spacesChaitanya Hazarey
Fixed the following warnings issued by checkpatch.pl WARNING: please, no space before tabs Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26Staging: rtl8192u: r8192U_wx.c Fixed code-style warningsChaitanya Hazarey
Fixed some of the following warning generated by checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: rtl8712, rtl8712: avoid lots of build warningsArnd Bergmann
The rtl8712 driver has an 'extern inline' function that contains an 'if', which causes lots of warnings with CONFIG_PROFILE_ALL_BRANCHES overriding the definition of 'if': drivers/staging/rtl8712/ieee80211.h:759:229: warning: '______f' is static but declared in inline function 'ieee80211_get_hdrlen' which is not static [enabled by default] This changes the driver to use 'static inline' instead, which happens to be the correct annotation anyway. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Larry Finger <Larry.Finger@lwfinger.net> Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: rtl8192u: r8192U_core.c: Cleaning up unclear and confusing codeRickard Strandqvist
Removes confusing and unclear code. Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19Staging: rtl8192u: r8192U_core.c Converted a C99 comment to fix code-style errorChaitanya Hazarey
Converted a C99 comment to fix the following error: ERROR: trailing statements should be on next line Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19Staging: rtl8192u: r8192U_core.c Fixed open brace { placementChaitanya Hazarey
Fixed open brace placement to address the following code-style errors: ERROR: that open brace { should be on the previous line Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19Staging: rtl8192u: r8192U_core.c Converted some C99 comments to fix ↵Chaitanya Hazarey
code-style errors Converted some C99 warnings to fix the following error: ERROR: trailing statements should be on next line Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19Staging: rtl8192u: r8192U_core.c Rearranged statements to fix code-style errorsChaitanya Hazarey
Rearranged statements around if and switch statements to address the following error: ERROR: trailing statements should be on next line Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19Staging: rtl8192u: r8192U_core.c Added a space after ','Chaitanya Hazarey
Added spaces after ',' to fix the following warning: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19Staging: rtl8192u: r8192U_wx.c Removed some more commented out dead codeChaitanya Hazarey
Removed dead code from the file. Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging: rtl8192u: remove checks for CONFIG_IEEE80211_CRYPT_TKIPPaul Bolle
Ever since rtl8192u was added as a staging driver in v2.6.33 it contained checks for CONFIG_IEEE80211_CRYPT_TKIP. But the Kconfig symbol IEEE80211_CRYPT_TKIP was renamed to LIB80211_CRYPT_TKIP in v2.6.29. So these checks have always evaluated to false. And these checks were rather odd to begin with, since rtl8192u comes with its own ieee80211 stack, which has support for TKIP built in. Now the safe and easy thing to do here would be to remove these checks and the code they hide. But it turns out that with some minor cleanup the code currently hidden behind these checks builds cleanly. And by building it we allow the people actually running this code to test whether it is any good. That minor cleanup is needed because ieee80211_encrypt_fragment() accesses struct sk_buff's data member as if it is a struct ieee80211_hdr. It's not. See, in ieee80211_xmit() a struct ieee80211_hdr_3addrqos is skb_put() into the sk_buff with which ieee80211_encrypt_fragment() will be called. So switch from ieee80211_hdr to ieee80211_hdr_3addrqos here. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19Staging: rtl8192u: r8192U_wx.c Added a single space for code-style issueChaitanya Hazarey
Added a space around '|' to address: ERROR: need consistent spacing around '|' (ctx:VxW) Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19Staging: rtl8192u: r8192U_wx.c Removed all C99 commentsChaitanya Hazarey
To address the error - ERROR: do not use C99 // comments Removed all C99 comments. Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19Staging: rtl8192u: r8192U_wx.c removed commented dead codeChaitanya Hazarey
Removed dead code, commented out printks and DMESG. Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-29Staging: rtl8192u: r8192U_wx.c Fixed a misplaced braceChaitanya Hazarey
Fixed a misplaced brace in a function Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-28Staging: rtl8192u: r8192U_wx.c Added {} braces and newlinesChaitanya Hazarey
Added {} braces and newlines to address the following: ERROR: else should follow close brace '}' ERROR: space required before the open brace '{' ERROR: trailing statements should be on next line ERROR: space required before the open parenthesis '(' ERROR: that open brace { should be on the previous line Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-28Staging: rtl8192u: r8192U_wx.c Added missing spacesChaitanya Hazarey
Added spaces needed in the proper places to address: WARNING: please, no spaces at the start of a line WARNING: missing space after struct definition ERROR: spaces required around that '!=' (ctx:WxV) ERROR: spaces required around that '=' (ctx:WxV) ERROR: spaces required around that '=' (ctx:VxW) ERROR: spaces required around that '&&' (ctx:VxV) ERROR: spaces required around that '!=' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '==' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) ERROR: space required before the open parenthesis '(' ERROR: space required before the open brace '{' ERROR: space required after that ',' (ctx:VxV) ERROR: space required after that close brace '}' ERROR: space prohibited before that '--' (ctx:WxO) ERROR: space prohibited before that close parenthesis ')' ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-28Revert "staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIP"Greg Kroah-Hartman
This reverts commit f8cc81f845456c126fd0ab4d8379a8c47f5ca743. It breaks the build in linux-next. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Paul Bolle <pebolle@tiscali.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-27Staging: rtl8192u: r8180_93cx6.c Added missing spacesChaitanya Hazarey
Added spaces needed in the proper places to address: ERROR: space required after that ',' (ctx:VxV) ERROR: space required after that ';' (ctx:VxV) ERROR: space required after that close brace '}' ERROR: space required before the open brace '{' ERROR: space required before the open parenthesis '(' ERROR: spaces required around that '<' (ctx:VxV) ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '==' (ctx:VxV) Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-26staging: rtl8192u: remove checks for CONFIG_RTL8192_PMPaul Bolle
When the rtl8192u driver was added in v2.6.33 its code contained checks for CONFIG_RTL8192_PM. The related Kconfig symbol didn't exist then. It still doesn't exist now. Remove these checks. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-26staging: rtl8192u: rename CONFIG_IEEE80211_CRYPT_TKIPPaul Bolle
The Kconfig symbol IEEE80211_CRYPT_TKIP was renamed to LIB80211_CRYPT_TKIP in commit 274bfb8dc5ff ("lib80211: absorb crypto bits from net/ieee80211"). So when rtl8192u was added as a staging driver in v2.6.33 its checks for CONFIG_IEEE80211_CRYPT_TKIP were already outdated. Use CONFIG_LIB80211_CRYPT_TKIP instead, as was clearly intended. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-26drivers/staging: Remove useless return variablesPeter Senna Tschudin
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-25Staging: rtl8192u: r819xU_firmware_img.c Fixed checkpatch.pl ERRORsChaitanya Hazarey
Fixed a lot of errors of the type "ERROR: space required after that ',' (ctx:VxV)" Added tabs at the beginning of line. Signed-off-by: Chaitanya Hazarey <c@24.io> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-25staging: Convert __FUNCTION__ to __func__Joe Perches
Use the normal mechanism for emitting a function name. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-24Staging: rtl8192u: Remove old WIRELESS_EXT supportJoel Pelaez Jorge
Remove support for building against ancient WIRELESS_EXT versions, only leaving support for the current version: 22 Signed-off-by: Joel Pelaez Jorge <joelpelaez@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: rtl8192u: r8192U_core.c: Fix to remove null pointer checks that ↵Rickard Strandqvist
could never happen Removal of null pointer checks that could never happen Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging/rtl8192u: Put EXPORT_SYMBOL just after the exported functionBenoit Taine
Export of symbols statement must be placed right after the definition to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // <smpl> @ r @ identifier f; @@ - EXPORT_SYMBOL(f); @@ identifier r.f; @@ f(...) { ... } + EXPORT_SYMBOL(f); // </smpl> Signed-off-by: Benoit Taine <benoit.taine@lip6.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-03staging: rtl8192u: fix checkpatch braces warningRui Miguel Silva
fix some code style related to the use of braces in a one statement block Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-03staging: rtl8192u: cleanup a switch statementDan Carpenter
The white space was all wrong here. The case statements were indented too far. The if else blocks weren't indented at all. There was a break statement aligned with the else block and it confused my static checker because "were curly braces intended" so that the break statement was only on the else side? Also I removed some commented out code. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-25staging: rtl8192u: Fix indentation problemsLoïc Pellegrino
Fix coding style problems (incorrect indentation). Signed-off-by: Loïc Pellegrino <oort10@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-02Merge branch 'for-linus' of ↵Linus Torvalds
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial Pull trivial tree updates from Jiri Kosina: "Usual rocket science -- mostly documentation and comment updates" * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: sparse: fix comment doc: fix double words isdn: capi: fix "CAPI_VERSION" comment doc: DocBook: Fix typos in xml and template file Bluetooth: add module name for btwilink driver core: unexport static function create_syslog_header mmc: core: typo fix in printk specifier ARM: spear: clean up editing mistake net-sysfs: fix comment typo 'CONFIG_SYFS' doc: Insert MODULE_ in module-signing macros Documentation: update URL to hfsplus Technote 1150 gpio: update path to documentation ixgbe: Fix format string in ixgbe_fcoe. Kconfig: Remove useless "default N" lines user_namespace.c: Remove duplicated word in comment CREDITS: fix formatting treewide: Fix typo in Documentation/DocBook mm: Fix warning on make htmldocs caused by slab.c ata: ata-samsung_cf: cleanup in header file idr: remove unused prototype of idr_free()
2014-03-19staging: rtl8192u: make in r819xU_cmdpkt.c some local functions staticAna Rey
Make some local functions static. Fix sparse warnings in r819xU_cmdpkt.c drivers/staging/rtl8192u/r819xU_cmdpkt.c:185:6: warning: symbol 'cmdpkt_beacontimerinterrupt_819xusb' was not declared. Should it be static? Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19staging: rtl8192u: make in ieee80211/ieee80211_wx.c a local variable staticAna Rey
Make some local variable eee80211_modes static. Fix sparse warnings: drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c:42:19: warning: symbol 'ieee80211_modes' was not declared. Should it be static? Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19staging: rtl8192u: Delete 'fwSendNullPacket' function in r819xU_firmware.cAna Rey
Delete the fwSendNullPacket function that is not used in anywhere in the driver. Fix sparse warnings: drivers/staging/rtl8192u/r819xU_firmware.c:109:1: warning: symbol 'fwSendNullPacket' was not declared. Should it be static? Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19staging: rtl8192u: make in r819xU_firmware.c some local functions staticAna Rey
Make some local functions static (firmware_init_param, fw_download_code, CPUcheck_maincodeok_turnonCPU and CPUcheck_firmware_ready) and fix coding style in these function declarations when It is necessary. Fixed the following sparse warnings in r819xU_firmware.c CHECK drivers/staging/rtl8192u/r819xU_firmware.c drivers/staging/rtl8192u/r819xU_firmware.c:20:6: warning: symbol 'firmware_init_param' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_firmware.c:32:6: warning: symbol 'fw_download_code' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_firmware.c:159:6: warning: symbol 'CPUcheck_maincodeok_turnonCPU' was not declared. Should it be static? drivers/staging/rtl8192u/r819xU_firmware.c:208:6: warning: symbol 'CPUcheck_firmware_ready' was not declared. Should it be static? Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19staging: rtl8192u: Delete duplicate function declarations and extern keywordAna Rey
Delete the duplicate function declarations in r8192U_dm.c. These function declarations are defined in r8192U_dm.h. Also, delete the 'extern' keyword of these function definitions. Fix the following sparse warnings: CHECK drivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.c:159:1: warning: function 'init_hal_dm' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:179:13: warning: function 'deinit_hal_dm' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:245:17: warning: function 'hal_dm_watchdog' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:278:13: warning: function 'init_rate_adaptive' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:878:17: warning: function 'dm_txpower_trackingcallback' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:1609:13: warning: function 'dm_cck_txpower_adjust' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:1776:13: warning: function 'dm_change_dynamic_initgain_thresh' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:2543:13: warning: function 'dm_init_edca_turbo' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:2782:17: warning: function 'dm_rf_pathcheck_workitemcallback' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:3142:13: warning: function 'dm_fsync_timer_callback' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:3481:13: warning: function 'dm_shadow_init' with external linkage has definition Signed-off-by: Ana Rey <anarey@gmail.com> Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19staging: rtl8192u: Delete 'DM_CTSToSelfSetting' function in r8192U_dm.cAna Rey
Delete the DM_CTSToSelfSetting function that is not used in anywhere in the driver. Fix sparse warnings: drivers/staging/rtl8192u/r8192U_dm.c:2623:6: warning: symbol 'DM_CTSToSelfSetting' was not declared. Should it be static? Signed-off-by: Ana Rey <anarey@gmail.com> Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19staging: rtl8192u: Delete 'dm_change_fsync_setting' function in r8192U_dm.cAna Rey
Delete the 'dm_change_fsync_setting' function that is not used in anywhere in the driver. Fix sparse warnings: drivers/staging/rtl8192u/r8192U_dm.c:1812:6: warning: symbol 'dm_change_fsync_setting' was not declared. Should it be static? Signed-off-by: Ana Rey <anarey@gmail.com> Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19staging: rtl8192u: Fix whitespaces in function declarations in r8192U_dm.hAna Rey
Fix whitespaces in function declarations in r8192U_dm.h Signed-off-by: Ana Rey <anarey@gmail.com> Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: rtl8192u: Convert from printk into netdev_err or netdev_infoAna Rey
Convert from printk functions into netdev_err or netdev_info in ieee80211/dot11d.c Fix checkpatch.pl warning: WARNING: printk() should include KERN_ facility level WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: rtl8192u: Move export_symbol below its functionAna Rey
Move export_symbol below its function in ieee80211/dot11d.c Fix checkpatch.pl warning: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: rtl8192u: fix coding style in function definitionAna Rey
Remove innecessary spaces and indentation errors in function definition Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: rtl8192u: Add whitespace in ieee80211/dot11d.cAna Rey
Add whitespace in ieee80211/dot11d.c and fix coding style these lines when It is necessary Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: rtl8192u: Delete unnecesary braces in ieee80211/dot11d.cAna Rey
Delete unnecesary braces and fix coding style these lines when It is necessary in ieee80211/dot11d.c Fix checkpatch.pl errors: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: rtl8192u: Move open brace on the previous lineAna Rey
Move open brace on the previous line and fix coding style in these lines when It is necessary in ieee80211/dot11d.c Fix checkpatch.pl errors: ERROR: that open brace { should be on the previous line Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: rtl8192u: Clean-up comment line style in ieee80211/dot11d.cAna Rey
Convert style of comments from C99-style to C89 and fix coding style in these lines when It is necessary. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: rtl8192u: Delete commented code in ieee80211/dot11d.cAna Rey
Delete all commented code in ieee80211/dot11d.c that are not necessary. Signed-off-by: Ana Rey <anarey@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging:rtl8192u: drop explicit externsHimangi Saraogi
This patch removes use of explicit extern specifier and quietens the sparse warnings: drivers/staging/rtl8192u/r8192U_dm.c:159:1: warning: function 'init_hal_dm' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:179:13: warning: function 'deinit_hal_dm' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:245:17: warning: function 'hal_dm_watchdog' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:278:13: warning: function 'init_rate_adaptive' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:878:17: warning: function 'dm_txpower_trackingcallback' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:1609:13: warning: function 'dm_cck_txpower_adjust' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:1776:13: warning: function 'dm_change_dynamic_initgain_thresh' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:1846:1: warning: function 'dm_change_fsync_setting' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:1863:1: warning: function 'dm_change_rxpath_selection_setting' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:2543:13: warning: function 'dm_init_edca_turbo' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:2663:13: warning: function 'DM_CTSToSelfSetting' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:2782:17: warning: function 'dm_rf_pathcheck_workitemcallback' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:3142:13: warning: function 'dm_fsync_timer_callback' with external linkage has definition drivers/staging/rtl8192u/r8192U_dm.c:3481:13: warning: function 'dm_shadow_init' with external linkage has definition Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2024-10-19 22:36:04 +0000