From ee91592711ed90a1abfbb1b2ceadded11d685164 Mon Sep 17 00:00:00 2001 From: "Saul St. John" Date: Thu, 16 Aug 2012 15:42:30 -0500 Subject: bcma: don't leak memory for PCIE, MIPS, GBIT cores MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit bcma_scan_bus allocates a bcma_core for each core found on the bus, but the memory for cores handled by the bcma driver itself was not being freed when the bus was unregistered. This patch adds special handling for the PCIE, MIPS, and GBIT COMMON cores, to ensure that their memory allocation is freed as well. Note that this patch doesn't address the memory allocated for the CC core, as that was corrected in my previous patch "bcma: register cc core driver, device." Cc: Rafał Miłecki Signed-off-by: Saul St. John Signed-off-by: John W. Linville --- drivers/bcma/main.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/bcma/main.c b/drivers/bcma/main.c index a8f570d6907..432aeeedfd5 100644 --- a/drivers/bcma/main.c +++ b/drivers/bcma/main.c @@ -227,7 +227,17 @@ int __devinit bcma_bus_register(struct bcma_bus *bus) void bcma_bus_unregister(struct bcma_bus *bus) { + struct bcma_device *cores[3]; + + cores[0] = bcma_find_core(bus, BCMA_CORE_MIPS_74K); + cores[1] = bcma_find_core(bus, BCMA_CORE_PCIE); + cores[2] = bcma_find_core(bus, BCMA_CORE_4706_MAC_GBIT_COMMON); + bcma_unregister_cores(bus); + + kfree(cores[2]); + kfree(cores[1]); + kfree(cores[0]); } int __init bcma_bus_early_register(struct bcma_bus *bus, -- cgit v1.2.3-70-g09d2