From aa62f85d0c65712c24b4892e9eab929d5176cee2 Mon Sep 17 00:00:00 2001 From: Alan Cox Date: Wed, 27 Oct 2010 12:44:03 +0100 Subject: i2c-intel-mid: support for Moorestown and Medfield platform (Updated to address Ben's comments. With regard to the message segment restriction it's not something we hit on the actual platform so while I will investigate that further I don't think its a blocker to submission. At worst its a spot over-restrictive) From: Wen Wang Initial release of the driver. Updated and verified on hardware. Cleaned up as follows Alan Cox: Squash down the switches into tables, and use the PCI ident field. We could perhaps take this further and put the platform and port number into this. uint32t -> u32 bracketing of case statements spacing and '!' usage Check the speed (which is now 0/1/2) is valid and ignore otherwise. Fix remaining problems/suggestions from Jean's review Fix items from Ben's review Arjan van de Ven: Initial power management hooks Yong Wang : Shared IRQ support Wen Wang : D3 support Fixes for OCT test runs Interrupt optimisations Hong Liu The runtime PM code is working on the wrong device (i2c_adapter->dev). The correct one should be pci_dev->dev. This breaks attached i2c slave devices with runtime PM enabled. Slave device needs to runtime resume parent device before runtime resuming itself, but we always get error since we don't have pm_runtime callback for i2c_adapter->dev. Bin Yang : Update speed table Saadi Maalem : Clear all interrupts in the hardware init Celine Chotard : Correct ordering of clear/disable of IRQs Signed-off-by: Wen Wang Signed-off-by: Yong Wang Signed-off-by: Hong Liu Signed-off-by: Bin Yang Signed-off-by: Arjan van de Ven Signed-off-by: Alan Cox Signed-off-by: Ben Dooks --- drivers/i2c/busses/Kconfig | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'drivers/i2c/busses/Kconfig') diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 6539ac2907e..8fcdfbae64b 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -396,6 +396,15 @@ config I2C_IMX This driver can also be built as a module. If so, the module will be called i2c-imx. +config I2C_INTEL_MID + tristate "Intel Moorestown/Medfield Platform I2C controller" + help + Say Y here if you have an Intel Moorestown/Medfield platform I2C + controller. + + This support is also available as a module. If so, the module + will be called i2c-intel-mid. + config I2C_IOP3XX tristate "Intel IOPx3xx and IXP4xx on-chip I2C interface" depends on ARCH_IOP32X || ARCH_IOP33X || ARCH_IXP4XX || ARCH_IOP13XX -- cgit v1.2.3-70-g09d2 From 9cc11dee3ddf140e39b0088688bfe5ee45d63b41 Mon Sep 17 00:00:00 2001 From: Randy Dunlap Date: Fri, 29 Oct 2010 13:37:09 -0700 Subject: i2c-intel-mid: Driver depends on PCI i2c-intel-mid driver uses PCI data structs and interfaces, so it should depend on PCI. Fixes these build errors: drivers/i2c/busses/i2c-intel-mid.c:977: error: implicit declaration of function 'pci_request_region' drivers/i2c/busses/i2c-intel-mid.c:1077: error: implicit declaration of function 'pci_release_region' Signed-off-by: Randy Dunlap Cc: Ba Zheng Cc: Jean Delvare Cc: Ben Dooks Cc: linux-i2c@vger.kernel.org Signed-off-by: Ben Dooks --- drivers/i2c/busses/Kconfig | 1 + 1 file changed, 1 insertion(+) (limited to 'drivers/i2c/busses/Kconfig') diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 8fcdfbae64b..175ba23b67d 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -398,6 +398,7 @@ config I2C_IMX config I2C_INTEL_MID tristate "Intel Moorestown/Medfield Platform I2C controller" + depends on PCI help Say Y here if you have an Intel Moorestown/Medfield platform I2C controller. -- cgit v1.2.3-70-g09d2