From e6889b310eb997afe698fac9762203e11577af1e Mon Sep 17 00:00:00 2001 From: Tülin İzer Date: Fri, 17 May 2013 10:12:34 +0300 Subject: usb: devio: Fixed warning: 'use instead ' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch fixes warning: 'use instead ' found by checkpatch in usb/devio.c. Signed-off-by: Tülin İzer Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/devio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/usb/core/devio.c') diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index caefc800f29..9374937f13c 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -49,7 +49,7 @@ #include #include #include -#include +#include #include #include -- cgit v1.2.3-70-g09d2 From fa86ad0b63846d35b6989cefe24e46301b94a9f3 Mon Sep 17 00:00:00 2001 From: Tülin İzer Date: Fri, 17 May 2013 10:13:24 +0300 Subject: usb: devio: Fixed macro parenthesis error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch fixes error 'Macros with complex values should be enclosed in parenthesis' in USB/devio.c Signed-off-by: Tülin İzer Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/devio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'drivers/usb/core/devio.c') diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 9374937f13c..009bc3f2fde 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -56,7 +56,7 @@ #include "usb.h" #define USB_MAXBUS 64 -#define USB_DEVICE_MAX USB_MAXBUS * 128 +#define USB_DEVICE_MAX (USB_MAXBUS * 128) #define USB_SG_SIZE 16384 /* split-size for large txs */ /* Mutual exclusion for removal, open, and release */ -- cgit v1.2.3-70-g09d2 From 4baf0df7010e8d975edcd778604fc1b1fce30f37 Mon Sep 17 00:00:00 2001 From: Tülin İzer Date: Fri, 17 May 2013 10:13:58 +0300 Subject: usb: devio: Fixed error: 'do not use assignment in if condition' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This patch fixes error: 'do not use assignment in if condition' in USB/devio.c. Signed-off-by: Tülin İzer Signed-off-by: Greg Kroah-Hartman --- drivers/usb/core/devio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'drivers/usb/core/devio.c') diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c index 009bc3f2fde..47ff9b1c8a3 100644 --- a/drivers/usb/core/devio.c +++ b/drivers/usb/core/devio.c @@ -1800,7 +1800,8 @@ static int proc_ioctl(struct dev_state *ps, struct usbdevfs_ioctl *ctl) /* alloc buffer */ if ((size = _IOC_SIZE(ctl->ioctl_code)) > 0) { - if ((buf = kmalloc(size, GFP_KERNEL)) == NULL) + buf = kmalloc(size, GFP_KERNEL); + if (buf == NULL) return -ENOMEM; if ((_IOC_DIR(ctl->ioctl_code) & _IOC_WRITE)) { if (copy_from_user(buf, ctl->data, size)) { -- cgit v1.2.3-70-g09d2