From d4d3aa38d66d0313401534bff2e4647df0a6d538 Mon Sep 17 00:00:00 2001 From: Milosz Tanski Date: Tue, 3 Sep 2013 19:11:17 -0400 Subject: ceph: page still marked private_2 Previous patch that allowed us to cleanup most of the issues with pages marked as private_2 when calling ceph_readpages. However, there seams to be a case in the error case clean up in start read that still trigers this from time to time. I've only seen this one a couple times. BUG: Bad page state in process petabucket pfn:335b82 page:ffffea000cd6e080 count:0 mapcount:0 mapping: (null) index:0x0 page flags: 0x200000000001000(private_2) Call Trace: [] dump_stack+0x46/0x58 [] bad_page+0xc7/0x120 [] free_pages_prepare+0x10e/0x120 [] free_hot_cold_page+0x40/0x160 [] __put_single_page+0x27/0x30 [] put_page+0x25/0x40 [] ceph_readpages+0x2e9/0x6f0 [ceph] [] __do_page_cache_readahead+0x1af/0x260 Signed-off-by: Milosz Tanski Signed-off-by: Sage Weil --- fs/ceph/addr.c | 1 + 1 file changed, 1 insertion(+) (limited to 'fs/ceph/addr.c') diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c index 1fda9cf04a8..6df8bd48142 100644 --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -336,6 +336,7 @@ static int start_read(struct inode *inode, struct list_head *page_list, int max) page->index); if (add_to_page_cache_lru(page, &inode->i_data, page->index, GFP_NOFS)) { + ceph_fscache_uncache_page(inode, page); page_cache_release(page); dout("start_read %p add_to_page_cache failed %p\n", inode, page); -- cgit v1.2.3-70-g09d2