From 37529fe9f62835e1c11895a1895064748b032dc1 Mon Sep 17 00:00:00 2001 From: Lai Jiangshan Date: Wed, 26 Mar 2008 12:01:28 +0100 Subject: set relay file can not be read by pread(2) I found that relay files can be read by pread(2). I fix it, for relay files are not capable of seeking. Signed-off-by: Lai Jiangshan Signed-off-by: Jens Axboe --- kernel/relay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'kernel/relay.c') diff --git a/kernel/relay.c b/kernel/relay.c index 4c035a8a248..ed3f6cf2db8 100644 --- a/kernel/relay.c +++ b/kernel/relay.c @@ -736,7 +736,7 @@ static int relay_file_open(struct inode *inode, struct file *filp) kref_get(&buf->kref); filp->private_data = buf; - return 0; + return nonseekable_open(inode, filp); } /** -- cgit v1.2.3-70-g09d2 From 5eb7f9fa847b8ab6e4864bfb8cb45f370844a47c Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Wed, 26 Mar 2008 12:04:09 +0100 Subject: relay: set an spd_release() hook for splice relay doesn't reference the pages it adds, however we need a non-NULL hook or splice_to_pipe() can oops. Signed-off-by: Jens Axboe --- kernel/relay.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'kernel/relay.c') diff --git a/kernel/relay.c b/kernel/relay.c index ed3f6cf2db8..d6204a48581 100644 --- a/kernel/relay.c +++ b/kernel/relay.c @@ -1056,6 +1056,10 @@ static struct pipe_buf_operations relay_pipe_buf_ops = { .get = generic_pipe_buf_get, }; +static void relay_page_release(struct splice_pipe_desc *spd, unsigned int i) +{ +} + /* * subbuf_splice_actor - splice up to one subbuf's worth of data */ @@ -1083,6 +1087,7 @@ static int subbuf_splice_actor(struct file *in, .partial = partial, .flags = flags, .ops = &relay_pipe_buf_ops, + .spd_release = relay_page_release, }; if (rbuf->subbufs_produced == rbuf->subbufs_consumed) -- cgit v1.2.3-70-g09d2