From 434b5a2e2dfd2a15bde68ed7ed2d4150eceb04e0 Mon Sep 17 00:00:00 2001 From: Al Viro Date: Sat, 6 Apr 2013 13:53:56 -0400 Subject: sound_firmware: don't bother with filp_close() it's opened read-only and never installed into any descriptor tables; fput() will do just as well. Signed-off-by: Al Viro --- sound/sound_firmware.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'sound/sound_firmware.c') diff --git a/sound/sound_firmware.c b/sound/sound_firmware.c index e1490346805..b155137ee31 100644 --- a/sound/sound_firmware.c +++ b/sound/sound_firmware.c @@ -1,6 +1,7 @@ #include #include #include +#include #include #include #include @@ -23,14 +24,14 @@ static int do_mod_firmware_load(const char *fn, char **fp) if (l <= 0 || l > 131072) { printk(KERN_INFO "Invalid firmware '%s'\n", fn); - filp_close(filp, NULL); + fput(filp); return 0; } dp = vmalloc(l); if (dp == NULL) { printk(KERN_INFO "Out of memory loading '%s'.\n", fn); - filp_close(filp, NULL); + fput(filp); return 0; } pos = 0; @@ -38,10 +39,10 @@ static int do_mod_firmware_load(const char *fn, char **fp) { printk(KERN_INFO "Failed to read '%s'.\n", fn); vfree(dp); - filp_close(filp, NULL); + fput(filp); return 0; } - filp_close(filp, NULL); + fput(filp); *fp = dp; return (int) l; } -- cgit v1.2.3-70-g09d2