summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChangli Gao <xiaosuo@gmail.com>2010-12-14 03:09:15 +0000
committerDavid S. Miller <davem@davemloft.net>2010-12-16 13:16:06 -0800
commitb236da6931e2482bfe44a7865dd4e7bb036f3496 (patch)
treecf383f0fd1d4b1091e60413fe1aa6a054f6c6a58
parentcaafa84251b886feb6cdf23d50e2cc99dcdaaaf3 (diff)
net: use NUMA_NO_NODE instead of the magic number -1
Signed-off-by: Changli Gao <xiaosuo@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--include/linux/netdevice.h2
-rw-r--r--net/core/dev.c2
-rw-r--r--net/core/net-sysfs.c3
3 files changed, 4 insertions, 3 deletions
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 445e6825f8e..cc916c5c327 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -530,7 +530,7 @@ static inline int netdev_queue_numa_node_read(const struct netdev_queue *q)
#if defined(CONFIG_XPS) && defined(CONFIG_NUMA)
return q->numa_node;
#else
- return -1;
+ return NUMA_NO_NODE;
#endif
}
diff --git a/net/core/dev.c b/net/core/dev.c
index b25dd087f06..7ac26d2b972 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -5121,7 +5121,7 @@ static void netdev_init_one_queue(struct net_device *dev,
spin_lock_init(&queue->_xmit_lock);
netdev_set_xmit_lockdep_class(&queue->_xmit_lock, dev->type);
queue->xmit_lock_owner = -1;
- netdev_queue_numa_node_write(queue, -1);
+ netdev_queue_numa_node_write(queue, NUMA_NO_NODE);
queue->dev = dev;
}
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 85e8b5326dd..e23c01be5a5 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -1009,7 +1009,8 @@ static ssize_t store_xps_map(struct netdev_queue *queue,
if (dev_maps)
call_rcu(&dev_maps->rcu, xps_dev_maps_release);
- netdev_queue_numa_node_write(queue, (numa_node >= 0) ? numa_node : -1);
+ netdev_queue_numa_node_write(queue, (numa_node >= 0) ? numa_node :
+ NUMA_NO_NODE);
mutex_unlock(&xps_map_mutex);