summaryrefslogtreecommitdiffstats
path: root/Documentation
diff options
context:
space:
mode:
authorAnatolij Gustschin <agust@denx.de>2010-07-01 14:21:39 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2010-08-02 15:36:02 -0300
commit1bb6419433433e845f7bc47651ad246b2e65c6fa (patch)
tree56d9feec496430d29a450480d3908ea380daed92 /Documentation
parent2030c0325aa3d430b7bb9ec99da0295f49d183ef (diff)
V4L/DVB: v4l2-dev: fix memory leak
Since commit b4028437876866aba4747a655ede00f892089e14 the 'driver_data' field resides in device's struct device_private which may be allocated by dev_set_drvdata() if device_private struct was not allocated previously. dev_set_drvdata() is used in video_set_drvdata() to set the driver's private data pointer in v4l2 drivers. Setting the private data _before_ registering the v4l2 device results in a memory leak since __video_register_device() also calls video_set_drvdata(), but after zeroing the device structure. Thus, the reference to the previously allocated device_private struct goes lost and a new device_private will be allocated. All v4l drivers which call video_set_drvdata() _before_ calling video_register_device() are affected. The patch fixes __video_register_device() to preserve previously allocated device_private reference. Caught by kmemleak. Signed-off-by: Anatolij Gustschin <agust@denx.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'Documentation')
0 files changed, 0 insertions, 0 deletions