diff options
| author | Greg KH <gregkh@suse.de> | 2008-01-30 13:29:58 +0100 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2008-01-30 13:29:58 +0100 |
| commit | 213eca7f4888e9817e8076cdab6b9f7295c181f6 (patch) | |
| tree | 94b88ee10d6748f20d944eebb2447390ae5b62a4 /arch/x86/kernel/cpu/mcheck/mce_amd_64.c | |
| parent | 85004cc367abc000aa36c0d0e270ab609a68b0cb (diff) | |
kobj: fix threshold_init_device/kobject_uevent_env oops
the logic in this function is just crazy. It's recursive, but we
can circumvent the creation for the kobject and whole creation of the
threshold_block if some conditions are met. That's why we see the
allocate_threshold_blocks so many times in the callstack, yet only a few
kobjects created.
Then we blow up in kobject_uevent_env() on the first debug printk.
Which means that we are just passing in garbage.
Man, this is one time that comments in code would have been very nice to
have, and why forward goto's into major code blocks are just evil...
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'arch/x86/kernel/cpu/mcheck/mce_amd_64.c')
| -rw-r--r-- | arch/x86/kernel/cpu/mcheck/mce_amd_64.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd_64.c b/arch/x86/kernel/cpu/mcheck/mce_amd_64.c index 753588755fe..073afa7dd89 100644 --- a/arch/x86/kernel/cpu/mcheck/mce_amd_64.c +++ b/arch/x86/kernel/cpu/mcheck/mce_amd_64.c @@ -450,7 +450,8 @@ recurse: if (err) goto out_free; - kobject_uevent(&b->kobj, KOBJ_ADD); + if (b) + kobject_uevent(&b->kobj, KOBJ_ADD); return err; |