summaryrefslogtreecommitdiffstats
path: root/drivers/net/wireless/iwlwifi/dvm/tx.c
diff options
context:
space:
mode:
authorTim Gardner <tim.gardner@canonical.com>2012-12-07 06:28:34 -0700
committerJohannes Berg <johannes.berg@intel.com>2012-12-10 22:38:58 +0100
commit8907a6fb6281a9aa25df2c7e2996cedcd6e5559f (patch)
tree9750b7669af88d82789ae0d11a31f95f327a5124 /drivers/net/wireless/iwlwifi/dvm/tx.c
parentc8a8ab4472619e6936a224c5a950750d640aefbb (diff)
iwlwifi: iwlagn_request_scan: Fix check for priv->scan_request
The WARN_ON_ONCE() check for scan_request will not correctly detect a NULL pointer for scan_type == IWL_SCAN_NORMAL. Make it explicit that the check only applies to normal scans. Convert WARN_ON_ONCE to WARN_ON since priv->scan_request really _can't_ be NULL for normal scans. If it is then we should emit frequent warnings. This smatch warning led to scrutiny of iwlagn_request_scan(): drivers/net/wireless/iwlwifi/dvm/scan.c:894 iwlagn_request_scan() error: we previously assumed 'priv->scan_request' could be null (see line 792) Signed-off-by: Tim Gardner <tim.gardner@canonical.com> Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'drivers/net/wireless/iwlwifi/dvm/tx.c')
0 files changed, 0 insertions, 0 deletions