diff options
author | Oleg Nesterov <oleg@redhat.com> | 2012-07-29 20:22:44 +0200 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2012-07-30 11:27:24 +0200 |
commit | f4d6dfe55115efe981b4b5f37183ddccaaa792f0 (patch) | |
tree | 2d81b1b5a17334895282b42de6134b4e2dcf9f24 /kernel/test_kprobes.c | |
parent | cb113b47d098185f3f1f67e8300d05ddce842b66 (diff) |
uprobes: Fix register_for_each_vma()->vma_address() check
1. register_for_each_vma() checks that vma_address() == vaddr,
but this is not enough. We should also ensure that
vaddr >= vm_start, find_vma() guarantees "vaddr < vm_end" only.
2. After the prevous changes, register_for_each_vma() is the
only reason why vma_address() has to return loff_t, all other
users know that we have the valid mapping at this offset and
thus the overflow is not possible.
Change the code to use vaddr_to_offset() instead, imho this looks
more clean/understandable and now we can change vma_address().
3. While at it, remove the unnecessary type-cast.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar.vnet.ibm.com>
Cc: Anton Arapov <anton@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20120729182244.GA20362@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/test_kprobes.c')
0 files changed, 0 insertions, 0 deletions