summaryrefslogtreecommitdiffstats
path: root/lib/mpi/mpi-inline.h
diff options
context:
space:
mode:
authorIan Abbott <abbotti@mev.co.uk>2012-10-03 16:25:18 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-10-22 11:46:35 -0700
commit2db012bd40b889d8e5483d3daa07af04c4c109d8 (patch)
treea5da369fb3beec3005faf761f2fa38ed2a3761f6 /lib/mpi/mpi-inline.h
parentaaeb61a97b7159ebe30b18a422d04eeabfa8790b (diff)
staging: comedi: amplc_pc236: fix possible NULL deref during detach
`pc236_detach()` is called by the comedi core to clean up if either `pc236_attach()` or `pc236_attach_pci()` returns an error. It sets `thisboard` to the return value of `comedi_board(dev)` and assumes it is non-null. This is a valid assumption if `pc236_attach()` fails, but not if `pc236_attach_pci()` fails, leading to a possible NULL pointer dereference. Check `thisboard` at the top of `pc236_detach()` and return early if it is `NULL`. This is okay because the only other thing that could have been allocated is `dev->private` and that is freed by the comedi core, not by this function. Cc: <stable@vger.kernel.org> # 3.6.x Signed-off-by: Ian Abbott <abbotti@mev.co.uk> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/mpi/mpi-inline.h')
0 files changed, 0 insertions, 0 deletions