diff options
author | Paul Durrant <Paul.Durrant@citrix.com> | 2013-12-23 09:27:17 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-12-29 22:31:30 -0500 |
commit | ac3d5ac277352fe6e27809286768e9f1f8aa388d (patch) | |
tree | 1291e41ffe15d90e5e7f6b6d019b62b9d1bbdaa6 /net | |
parent | 7a399e3a2e05bc580a78ea72371b3896827f72e1 (diff) |
xen-netback: fix guest-receive-side array sizes
The sizes chosen for the metadata and grant_copy_op arrays on the guest
receive size are wrong;
- The meta array is needlessly twice the ring size, when we only ever
consume a single array element per RX ring slot
- The grant_copy_op array is way too small. It's sized based on a bogus
assumption: that at most two copy ops will be used per ring slot. This
may have been true at some point in the past but it's clear from looking
at start_new_rx_buffer() that a new ring slot is only consumed if a frag
would overflow the current slot (plus some other conditions) so the actual
limit is MAX_SKB_FRAGS grant_copy_ops per ring slot.
This patch fixes those two sizing issues and, because grant_copy_ops grows
so much, it pulls it out into a separate chunk of vmalloc()ed memory.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions