summaryrefslogtreecommitdiffstats
path: root/tools/perf/builtin-annotate.c
diff options
context:
space:
mode:
authorIngo Molnar <mingo@kernel.org>2013-10-15 07:05:51 +0200
committerIngo Molnar <mingo@kernel.org>2013-10-15 11:55:46 +0200
commit1ff9ecf797e398b9937d9da4c2236f4140b96339 (patch)
tree568ea3af4009cd513540f2541b55132ab186ed43 /tools/perf/builtin-annotate.c
parent426ee9e3bbc478ed9c0a079a4270f6095f0eb975 (diff)
parent784f3390f9bd900adfb3b0373615e105a0d9749a (diff)
Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core
Pull perf/core improvements and fixes from Arnaldo Carvalho de Melo: * kcore annotation improvements, including build-id cache support, multi map 'call' instruction navigation fixes, kcore address validation, objdump workarounds. From Adrian Hunter. * 'trace' beautifiers for lots of syscall arguments, from Arnaldo Carvalho de Melo. * More compact 'trace' output by suppressing zeroed args, from Arnaldo Carvalho de Melo. * Show thread COMM by default in 'trace', from Arnaldo Carvalho de Melo. * Show path associated with fd in live sessions, using a 'vfs_getname' 'perf probe' created dynamic tracepoint or by looking at /proc/pid/fd, from Arnaldo Carvalho de Melo. * Memory and mmap leak fixes from Chenggang Qin. * Add option to show full timestamp in 'trace', from David Ahern. * Add 'record' command in 'trace', to record raw_syscalls:*, from David Ahern. * Add summary option to dump syscall statistics in 'trace', from David Ahern. * Fix comm resolution in 'trace' when reading events from file, from David Ahern. * Improved messages when doing profiling in all or a subset of CPUs using a workload as the session delimitator, as in: 'perf stat --cpu 0,2 sleep 10s' from Arnaldo Carvalho de Melo. * Add units to nanosec-based counters in 'perf stat', from David Ahern. * Assorted build fixes for from David Ahern and Jiri Olsa. * 'perf lock' fixes and cleanups, from Davidlohr Bueso. * Memory leak fixes in 'perf test', from Felipe Pena. * Build system super speedups, from Ingo Molnar. * Fix mmap_read event overflow, from Jiri Olsa. * Code cleanups from Jiri Olsa. * Allow specifying B/K/M/G unit to the --mmap-pages arguments, from Jiri Olsa. * Separate the GTK support in a separate libperf-gtk.so DSO, that is only loaded when --gtk is specified, from Namhyung Kim. * Fixes for some memory leaks, from Namhyumg Kim. * Fix srcline sort key behavior, from Namhyung Kim. * Fix failing assertions in numa bench, from Petr Holasek. * perf bash completion fixes and improvements from Ramkumar Ramachandra. * Improve error messages in 'trace', providing hints about system configuration steps needed for using it, from Ramkumar Ramachandra. * Remove bogus info when using 'perf stat' -e cycles/instructions, from Ramkumar Ramachandra. * Support for Openembedded/Yocto -dbg packages, from Ricardo Ribalda Delgado. * Implement addr2line directly using libbfd, from Roberto Vitillo. * Add new option --ignore-vmlinux for perf top, from Willy Tarreau. Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'tools/perf/builtin-annotate.c')
-rw-r--r--tools/perf/builtin-annotate.c26
1 files changed, 23 insertions, 3 deletions
diff --git a/tools/perf/builtin-annotate.c b/tools/perf/builtin-annotate.c
index 0393d980051..94f9a8e7811 100644
--- a/tools/perf/builtin-annotate.c
+++ b/tools/perf/builtin-annotate.c
@@ -30,6 +30,7 @@
#include "util/tool.h"
#include "arch/common.h"
+#include <dlfcn.h>
#include <linux/bitmap.h>
struct perf_annotate {
@@ -142,8 +143,18 @@ find_next:
if (use_browser == 2) {
int ret;
+ int (*annotate)(struct hist_entry *he,
+ struct perf_evsel *evsel,
+ struct hist_browser_timer *hbt);
+
+ annotate = dlsym(perf_gtk_handle,
+ "hist_entry__gtk_annotate");
+ if (annotate == NULL) {
+ ui__error("GTK browser not found!\n");
+ return;
+ }
- ret = hist_entry__gtk_annotate(he, evsel, NULL);
+ ret = annotate(he, evsel, NULL);
if (!ret || !ann->skip_missing)
return;
@@ -247,8 +258,17 @@ static int __cmd_annotate(struct perf_annotate *ann)
goto out_delete;
}
- if (use_browser == 2)
- perf_gtk__show_annotations();
+ if (use_browser == 2) {
+ void (*show_annotations)(void);
+
+ show_annotations = dlsym(perf_gtk_handle,
+ "perf_gtk__show_annotations");
+ if (show_annotations == NULL) {
+ ui__error("GTK browser not found!\n");
+ goto out_delete;
+ }
+ show_annotations();
+ }
out_delete:
/*