summaryrefslogtreecommitdiffstats
path: root/drivers/staging/cxt1e1
AgeCommit message (Collapse)Author
2014-07-01staging: cxt1e1: remove driverKristina Martšenko
Remove the driver as it hasn't been cleaned up and it doesn't look like anyone is going to work on it anymore. This can be reverted if someone wants to work to fix the remaining issues the driver has. Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com> Cc: Bob Beers <bob.beers@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-26staging: cxt1e1: fix sbeCrc function declarationPawel Lebioda
This patch fixes the following sparse warning: drivers/staging/cxt1e1/sbecrc.c:86:1: warning: symbol 'sbeCrc' was not declared. Should it be static? Furthermore it fixes wring sbeCrc return type in function declaration. Signed-off-by: Pawel Lebioda <pawel.lebioda89@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-06-19staging cxt1e1: refactored ring buffer dump functions to avoid sparse warningsWolfgang Ocker
Sparse spit out these warnings: drivers/staging/cxt1e1/musycc.c:68:1: warning: context imbalance in 'musycc_dump_rxbuffer_ring' - different lock contexts for basic block drivers/staging/cxt1e1/musycc.c:136:1: warning: context imbalance in 'musycc_dump_txbuffer_ring' - different lock contexts for basic block The new functions musycc_dump_[rt]xbuffer_ring_locked() assume that the lock is held. musycc_dump_[rt]xbuffer_ring() take the lock. Signed-off-by: Wolfgang Ocker <weo@weo1.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-26staging: ctx1e1: remove checks for three macrosPaul Bolle
When the ctx1e1 driver was added in v2.6.35 it contained checks for CONFIG_SBE_HDLC_V7, CONFIG_SBE_WAN256T3_HDLC_V7, and CONFIG_SBE_WAN256T3_NCOMM (and MODULE variants). The related Kconfig symbols didn't exist then. They still don't exist now. Remove these checks. Do some related cleaning up and remove the unused V7() macro too. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: cxt1e1: remove set a value to static variableDaeseok Youn
cleanup checkpatch.pl error: ERROR: do not initialise statics to 0 or NULL Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: cxt1e1: Fix line length over 80 characters in musycc.cDaeseok Youn
clean up checkpatch.pl warning: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: cxt1e1: remove redundant curly braces in musycc.cDaeseok Youn
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: cxt1e1: remove dead code in musycc.cDaeseok Youn
Removes "#if 0" blocks. And the musycc_dump_rxbuffer_ring(ch, 0) which is commented out puts in RLD_DEBUG block and uncommented. Because this function may be used for debugging. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-05-23staging: cxt1e1: Fix no spaces at the start of a line in musycc.cDaeseok Youn
clean up checkpatch.pl warning: WARNING: please no spaces at the start of a line in Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-26staging: cxt1e1: Avoid using 0 instead of NULLThomas Vegas
Fixed the following sparse warnings: drivers/staging/cxt1e1/hwprobe.c:162:38: warning: Using plain integer as NULL pointer drivers/staging/cxt1e1/hwprobe.c:163:38: warning: Using plain integer as NULL pointer drivers/staging/cxt1e1/hwprobe.c:179:46: warning: Using plain integer as NULL pointer drivers/staging/cxt1e1/hwprobe.c:184:46: warning: Using plain integer as NULL pointer Signed-off-by: Thomas Vegas <thomas_75@safe-mail.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: cxt1e1: replace OS_kmalloc/OS_kfree with kzalloc/kfreeDaeseok Youn
Replace OS_kmalloc/OS_kfree with kzalloc/kfree. And also some allocation doesn't need to use GFP_DMA so just use GFP_KERNEL. c4_new() function is never called, remove it. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18STAGING: cxt1e1: Remove curly bracesMichael Welling
Removes unnecessary curly braces from for loop in eeprom_delay. Signed-off-by: Michael Welling <mwelling@ieee.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18STAGING: cxt1e1: More formatting fixesMichael Welling
Removes parens as are not necessary for return. Signed-off-by: Michael Welling <mwelling@ieee.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18STAGING: cxt1e1: Formatting fixes checkpatch issuesMichael Welling
Removes spaces before & where needed. Signed-off-by: Michael Welling <mwelling@ieee.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18STAGING: cxt1e1: Remove volatile variableMichael Welling
Removes volatile variable. Signed-off-by: Michael Welling <mwelling@ieee.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18STAGING: cxt1e1: Fixes comment blocksMichael Welling
Comment block fixes. Signed-off-by: Michael Welling <mwelling@ieee.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18STAGING: cxt1e1: Indentation fixesMichael Welling
Indentation fixes using Lindent. Signed-off-by: Michael Welling <mwelling@ieee.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18STAGING: cxt1e1: Remove sparse warningsMichael Welling
Removes sparse warnings by including a header and adding static to some functions. Signed-off-by: Michael Welling <mwelling@ieee.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-04-18staging: cxt1e1: hwprobe: fix incorrect type in assignmentMatei Oprea
This patch fixes "incorrect type in argument 1" warning from sparse. Signed-off-by: Matei Oprea <eu@opreamatei.ro> Cc: ROSEdu Kernel Community <firefly@lists.rosedu.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19Staging: cxt1e1: Fix externs should be avoided in .c files in comet.cEbru Akagunduz
Fix checkpatch.pl issues with externs should be avoided in comet.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-19Staging: cxt1e1: Fix use of volatile is usually wrong in comet.cEbru Akagunduz
Fix checkpatch.pl issues with use of volatile is usually wrong in comet.c Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: cxt1e1: remove unneeded mkret() callsDaeseok Youn
The mkret() change a value of error from positive to negative. This patch is modified to return negative value when it failed. It doesn't need to call with function for changing from positive to negative. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: cxt1e1: Fix Sparse Warning for Static Declarations in linux.cHimangi Saraogi
This patch fixes the following sparse warnings: drivers/staging/cxt1e1/linux.c:106:13: warning: symbol 'log_level_default' was not declared. Should it be static? drivers/staging/cxt1e1/linux.c:110:13: warning: symbol 'max_mru_default' was not declared. Should it be static? drivers/staging/cxt1e1/linux.c:255:1: warning: symbol 'c4_linux_interrupt' was not declared. Should it be static? drivers/staging/cxt1e1/linux.c:265:1: warning: symbol 'c4_ebus_interrupt' was not declared. Should it be static? Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: cxt1e1: Fix do not use // c99 commentsGulsah Kose
This patch fixes "do not use // C99 comments" errors in linux.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-18staging: cxt1e1: Fix line over 80 characters.Gulsah Kose
Fix checkpatch.pl issues with line over 80 characters in comet.c Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-17staging: cxt1e1: remove redundant memset() callDaeseok Youn
The banner array doens't need to set to 0. sprintf() adds a terminating '\0'. And the sn array can be declared and initialized to zero. So remove redundant memset() with zero. Remove unnecessary cast for memcpy(). Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-17staging: cxt1e1: remove redundant memset() callDaeseok Youn
The name array doens't need to set to 0. Because sprintf/snprintf adds a terminating '\0'. And also it doesn't need to assign name array address to np pointer. Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-17Merge 3.14-rc7 into staging-nextGreg Kroah-Hartman
This resolves a merge issue with drivers/staging/cxt1e1/linux.c that was fixed in a report from Stephen Rothwell Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-16staging: cxt1e1: Fix space prohibited between function name and open parenthesisGulsah Kose
Fix checkpatch.pl issues with space prohibited between function name and open parenthesis in libsbew.h Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-13staging: cxt1e1: Removed assignments from if statements.Chi Pham
Assignments removed from if statements. Fixed checkpatch warning such as indentation and negative error returns in adjacent code. Coccinelle was used for this patch. The following script found the match: @simple@ expression E1, E2; statement S1, S2; @@ + E1 = E2; if ( - (E1 = E2) + E1 ) S1 else S2 @left@ expression E0, E1, E2; statement S1, S2; @@ + E1 = E2; if ( - (E1 = E2) + E1 == E0 ) S1 else S2 Signed-off-by: Chi Pham <fempsci@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-13staging:cxt1e1:remove unused code with #if 0Himangi Saraogi
The functions musycc_del_chan and musycc_del_chan_stats are not being used at the moment and may not be required. Remove them for now (with #if 0) till it is decided whether it is really required. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
2014-03-08staging: cxt1e1: change declaration of TWV_tableShaun Laing
Changes the declaration of TWV_table to 'static void' to eliminate a sparse "should it be static" warning. Signed-off-by: Shaun Laing <shaun@xresource.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-08staging: cxt1e1: fix checkpatch errors with open brace '{'Daeseok Youn
clean up checkpatch.pl error in linux.c: ERROR: that open brace { should be on the previous line Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-08staging: cxt1e1: fix checkpatch error 'assignment in if condition'Daeseok Youn
checkpatch.pl error in linux.c: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-07Staging:cxt1e1:musycc:remove assignment in if conditionHimangi Saraogi
This patch removes the assignment in if conditions to do away with the checkpatch warning :'do not use assignment in if condition'. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-06staging: cxt1e1: removed version string declarationShaun Laing
Removed the unneeded pmcc4_OSSI_release version string, as well as the now unused 'release' element of the sbe_card_info struct. This also resolves a sparse "should it be static" warning. Signed-off-by: Shaun Laing <shaun@xresource.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-04staging: cxt1e1: Add extern keyword for sparse 'static' warningShaun Laing
Resolve sparse "warning: symbol '...' was not declared. Should it be static?" messages. Includes "comet_tables.h", which contains extern declarations for the variables defined in comet_tables.c. Signed-off-by: Shaun Laing <shaun@xresource.ca> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-04staging: cxt1e1: Fix line length over 80 characters in linux.cDaeseok Youn
clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-04staging: cxt1e1: Fix no spaces at the start of a line in linux.cDaeseok Youn
clean up checkpatch.pl warnings: WARNING: please no spaces at the start of a line in Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-04staging: cxt1e1: remove space between function name and parenthesisDaeseok Youn
clean up checkpatch.pl warnings in linux.c: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-04staging: cxt1e1: fix checkpatch errors with open brace '{'Daeseok Youn
clean up checkpatch.pl error: ERROR: that open brace { should be on the previous line Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-04staging: cxt1e1: fix checkpatch error 'assignment in if condition'Daeseok Youn
checkpatch.pl error: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-04Staging: cxt1e1: Fix line length over 80 characters in hwprobe.cDaeseok Youn
clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-03-04staging/cxt1e1/linux.c: Correct arbitrary memory write in c4_ioctl()Salva Peiró
The function c4_ioctl() writes data from user in ifr->ifr_data to the kernel struct data arg, without any iolen bounds checking. This can lead to a arbitrary write outside of the struct data arg. Corrected by adding bounds-checking of iolen before the copy_from_user(). Signed-off-by: Salva Peiró <speiro@ai2.upv.es> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-28staging: cxt1e1: Fix no spaces at the start of a line in hwprobe.cDaeseok Youn
clean up checkpatch.pl warnings: WARNING: please no spaces at the start of a line in Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-28staging: cxt1e1: remove space between function name and parenthesisDaeseok Youn
clean up checkpatch.pl warnings: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-28staging: cxt1e1: remove unused variableDaeseok Youn
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27Staging: cxt1e1: Fix line length over 80 characters in functions.cMonam Agarwal
This patch fixes the following checkpatch.pl warning in functions.c WARNING: Line length over 80 characters Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27Staging: cxt1e1: Fix space prohibited between function name and open ↵Monam Agarwal
parenthesis '(' This patch fixes the following checkpatch.pl warning in functions.c WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-02-27Staging: cxt1e1: Fix no spaces at the start of a line in functions.cMonam Agarwal
This patch fixes the following checkpatch.pl warning in functions.c WARNING: please no spaces at the start of a line in Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
generated by cgit v1.2.3-70-g09d2 (git 2.46.0) at 2024-10-20 00:31:08 +0000