diff options
author | Thomas De Schampheleire <patrickdepinguin@gmail.com> | 2013-12-20 22:31:30 +0100 |
---|---|---|
committer | Thomas Petazzoni <thomas.petazzoni@free-electrons.com> | 2013-12-25 12:21:39 +0100 |
commit | 35eaed8d07bdc73a83990bc306fcdb08b2e70eaf (patch) | |
tree | fe38a982159d30eeadbc0a30462da1676bdd11b0 /package/gadgetfs-test | |
parent | 142a81d60533ef179300c44fd29aaefbfae62d3a (diff) |
Config.in files: use if/endif instead of 'depends on' for main symbol
In the Config.in file of package foo, it often happens that there are other
symbols besides BR2_PACKAGE_FOO. Typically, these symbols only make sense
when foo itself is enabled. There are two ways to express this: with
depends on BR2_PACKAGE_FOO
in each extra symbol, or with
if BR2_PACKAGE_FOO
...
endif
around the entire set of extra symbols.
The if/endif approach avoids the repetition of 'depends on' statements on
multiple symbols, so this is clearly preferred. But even when there is only
one extra symbol, if/endif is a more logical choice:
- it is future-proof for when extra symbols are added
- it allows to have just one strategy instead of two (less confusion)
This patch modifies the Config.in files accordingly.
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Diffstat (limited to 'package/gadgetfs-test')
-rw-r--r-- | package/gadgetfs-test/Config.in | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/package/gadgetfs-test/Config.in b/package/gadgetfs-test/Config.in index c4b77396e..9afb0a2d9 100644 --- a/package/gadgetfs-test/Config.in +++ b/package/gadgetfs-test/Config.in @@ -4,10 +4,11 @@ config BR2_PACKAGE_GADGETFS_TEST help Test program for gadgetfs from linux-usb.org +if BR2_PACKAGE_GADGETFS_TEST + config BR2_PACKAGE_GADGETFS_TEST_USE_AIO bool "use asynchronous i/o" select BR2_PACKAGE_LIBAIO - depends on BR2_PACKAGE_GADGETFS_TEST # libaio is available only on few architectures depends on \ BR2_arm || BR2_armeb || BR2_avr32 || BR2_i386 || \ @@ -17,5 +18,7 @@ config BR2_PACKAGE_GADGETFS_TEST_USE_AIO Select this to have gadgetfs-test do asynchronous I/O using the libaio library. +endif + comment "gadgetfs-test needs a toolchain w/ threads" depends on !BR2_TOOLCHAIN_HAS_THREADS |