summaryrefslogtreecommitdiffstats
path: root/package/gstreamer
AgeCommit message (Collapse)Author
2014-12-22package: indentation cleanupJerzy Grzegorek
Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-12-11Rename BR2_PREFER_STATIC_LIB to BR2_STATIC_LIBSThomas Petazzoni
Since a while, the semantic of BR2_PREFER_STATIC_LIB has been changed from "prefer static libraries when possible" to "use only static libraries". The former semantic didn't make much sense, since the user had absolutely no control/idea of which package would use static libraries, and which packages would not. Therefore, for quite some time, we have been starting to enforce that BR2_PREFER_STATIC_LIB should really build everything with static libraries. As a consequence, this patch renames BR2_PREFER_STATIC_LIB to BR2_STATIC_LIBS, and adjust the Config.in option accordingly. This also helps preparing the addition of other options to select shared, shared+static or just static. Note that we have verified that this commit can be reproduced by simply doing a global rename of BR2_PREFER_STATIC_LIB to BR2_STATIC_LIBS plus adding BR2_PREFER_STATIC_LIB to Config.in.legacy. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
2014-10-26gst-ffmpeg: expand package description to describe libav usageDanomi Manchego
- Change URL to gst-ffmpeg page at the gstreamer site. - Note that gst-ffmpeg actually uses libav, not ffmpeg [anymore]. - Note that gst-ffmpeg is using an internal copy of libav, not a system copy. Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com> Acked-by: Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-10-26gst-ffmpeg: add --pkg-config to internal libav configure optionsDanomi Manchego
The internal copy of libav in gst-ffmpeg does not understand the PKG_CONFIG env variable, so it throws a line like this at the end of its configuration: WARNING: .../output/host/usr/bin/i686-pc-linux-gnu-pkg-config not found, library detection may fail. This patch adds the --pkg-config to let libav know where it is. Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com> Tested-by: Luca Ceresoli <luca@lucaceresoli.net> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-10-26gst-ffmpeg: add option to select GPL vs LGPL buildDanomi Manchego
Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-10-25gst-ffmpeg: allow usage of ARMv6 optimizations on ARMv7 platformsThomas Petazzoni
Contrary to the ffmpeg package, the gst-ffmpeg package was only allowing ARMv6 optimizations on ARMv6 platforms. This commit also allows ARMv6 optimizations on ARMv7 platforms, like the ffmpeg package does. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
2014-10-25gst-ffmpeg: use the new BR2_ARM_CPU_ARM* optionsThomas Petazzoni
Instead of using the Config.in options for each individual ARM core, use the newly introduced BR2_ARM_CPU_ARM* options, which exist per ARM architecture. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
2014-10-19infra: Move --enable/--disable-debug to package/Makefile.inBernd Kuhls
A lot of packages ignored BR2_ENABLE_DEBUG. This patch simplifies the handling of this option by adding the corresponding configure option to the global Makefile for target packages. For host packages --disable-debug is added to the global Makefile. Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-10-04packages: rename misc. occurrences of _OPT into _OPTSThomas De Schampheleire
To be consistent with the recent change of FOO_MAKE_OPT into FOO_MAKE_OPTS, change remaining occurrences of _OPT into _OPTS. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-10-04packages: rename FOO_CONF_OPT into FOO_CONF_OPTSThomas De Schampheleire
To be consistent with the recent change of FOO_MAKE_OPT into FOO_MAKE_OPTS, make the same change for FOO_CONF_OPT. Sed command used: find * -type f | xargs sed -i 's#_CONF_OPT\>#&S#g' Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-10-04packages: rename FOO_AUTORECONF_OPT into FOO_AUTORECONF_OPTSThomas De Schampheleire
To be consistent with the recent change of FOO_MAKE_OPT into FOO_MAKE_OPTS, make the same change for FOO_AUTORECONF_OPT. Sed command used: find * -type f | xargs sed -i 's#_AUTORECONF_OPT\>#&S#g' Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-08-21gstreamer{, 1}: fix unaligned access detection for arcAlexey Brodkin
Fixes the same issue as reported for microblaze here http://autobuild.buildroot.net/results/f49/f4914bb3999c8a7a0c0a2afdac5de40fb9058372/ Similar to the existing handling for avr32, microblaze and xtensa. Also add it for gstreamer1 for good measure as it was missing there as well. Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Cc: Anton Kolesov <akolesov@synopsys.com> Cc: Peter Korsgaard <peter@korsgaard.com> Cc: Baruch Siach <baruch@tkos.co.il> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-08-18pulseaudio: add dependency on atomic operationsAnton Kolesov
This fixes: http://autobuild.buildroot.net/results/d463f3bf730a600a07ed6cd33695bf45e9fd3540/ Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com> [yann.morin.1998@free.fr: use the new symbol; remove comment strings] Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-08-18cairo: add dependency on atomic operationsAnton Kolesov
This fixes: http://autobuild.buildroot.net/results/fadfaa9916724d310d0dda555a1db31bee1601d0/ Signed-off-by: Anton Kolesov <Anton.Kolesov@synopsys.com> [yann.morin.1998@free.fr: use the new symbol; remove comment strings; fix weston's comment] Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-08-03gst-fsl-plugins, libfslvpuwrap: add missing selectThomas Petazzoni
In order to select imx-vpu, packages must also select the freescale-imx package, otherwise, kconfig prints some warnings. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-07-31package: remove the trailing slash sign from <PKG>_SITE variableJerzy Grzegorek
Since the trailing slash is stripped from $($(PKG)_SITE) by pkg-generic.mk: $(call DOWNLOAD,$($(PKG)_SITE:/=)/$($(PKG)_SOURCE)) so it is redundant. This patch removes it from $(PKG)_SITE variable for BR consistency. Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-07-27gst-fsl-plugins: fix build for kernel headers >= 3.10Gary Bisson
This package couldn't build using a toolchain with kernel headers >= 3.10 because of the use of VIDIOC_DBG_G_CHIP_IDENT. As stated in videodev2.h, this ioctl should never be used. Signed-off-by: Gary Bisson <bisson.gary@gmail.com> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-07-15package/gst-fsl-plugins: add default platformYann E. MORIN
Set the default platform for gst-fsl-plugins, based on the one choosen as the generic Freescale i.MX platform. We can't use only this generic platform choice, as gst-fsl-plugins has support for more platforms. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Gary Bisson <bisson.gary@gmail.com> Cc: Hadrien Boutteville <hadrien.boutteville@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-07-15gst-fsl-plugins: bump to version 3.0.11Gary Bisson
As the VPU code is now apart from imx-lib, this package also depends on imx-vpu. Signed-off-by: Gary Bisson <bisson.gary@gmail.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> [yann.morin.1998@free.fr: slightly tweak commit log <80 chars] Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Hadrien Boutteville <hadrien.boutteville@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-22gst-ffmpeg: fix build on armv6 without thumb2 (e.g. RaspberryPi)Arnout Vandecappelle
[Thomas: rename existing patch and the one added by Arnout to follow the patch naming convention.] Cc: Marco Trapanese <marcotrapanese@gmail.com> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-06-01Merge branch 'next'Peter Korsgaard
Conflicts: package/gdb/Config.in.host Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-05-26powerpc: add BR2_POWERPC_CPU_HAS_ALTIVEC to replace adhoc deps/checksCody P Schafer
Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-05-17pulseaudio: uses fork(), not available on noMMU platformsThomas Petazzoni
Even though pulseaudio has some HAVE_FORK compile-time conditionals to avoid using fork(), those parts of pulseaudio are not using it. Since using pulseaudio on !MMU platforms is fairly unlikely, we simply disable it when no MMU is available, and propagate this dependency to the appropriate locations. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-05-08arch/arm: drop ARM(7TDMI/720T/740T) supportGustavo Zacarias
The toolchain currently doesn't build for nommu ARM and is in need of serious work. Problem is there are no emulation targets and real ARM(7TDMI/720T/740T) hardware that's capable of running linux (enough memory, having a memory controller...) is VERY rare and uses very old versions to make it usable. The ARM nommu focus should go into Cortex M series processors that are obtainable at reasonable cost on modern hardware that has external memory controllers. Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-04-15flac: needs wcharGustavo Zacarias
Fixes: http://autobuild.buildroot.net/results/873/873a1b3551c5fe04fa477fd682ff91fecdd41606/ Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-04-12gst-fsl-plugins: fix typo in commentPeter Korsgaard
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-04-11libfslcodec: needs a (e)glibc based toolchainPeter Korsgaard
The package contains prebuilt binaries linked against glibc. Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-04-06gst-fsl-plugins: Refresh one patch to fix buildVincent Stehlé
This fixes the following patch application error when building for i.MX6: Applying gst-fsl-plugins-0004-Fix-libgstfsl-linkage-add-lrt-for-shared-memory-func.patch using patch: patching file configure.ac Hunk #1 succeeded at 178 with fuzz 2 (offset 5 lines). patching file libs/Makefile.am Hunk #1 FAILED at 12. 1 out of 1 hunk FAILED -- saving rejects to file libs/Makefile.am.rej Patch failed! Please fix gst-fsl-plugins-0004-Fix-libgstfsl-linkage-add-lrt-for-shared-memory-func.patch! Signed-off-by: Vincent Stehlé <vincent.stehle@freescale.com> Cc: Peter Seiderer <ps.report@gmx.net> Cc: Eric Nelson <eric.nelson@boundarydevices.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-04-03Revert "gst-ffmpeg: fix build for xtensa"Max Filippov
This reverts commit 7e558aa0d87d86be1bbc91b284acd0d11378ee4e. Now that -mtext-section-literals is specified in the xtensa ABI this fix is no longer needed. Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2014-02-28Merge branch 'next'Peter Korsgaard
Conflicts: Makefile package/dmraid/Config.in package/gdb/Config.in.host package/linux-headers/linux-headers.mk package/python/python.mk package/python3/python3.mk package/rt-tests/Config.in package/sdl/sdl.mk package/systemd/systemd-01-fix-getty-unit.patch package/systemd/systemd-02-fix-page-size.patch package/systemd/systemd-03-uclibc-fix.patch package/udev/Config.in package/udisks/Config.in package/vlc/vlc.mk system/Config.in Quite some merge conflicts, hopefully I didn't screw up anything. Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-02-27gstreamer{,1}: fix unaligned access detection for microblazePeter Korsgaard
Fixes http://autobuild.buildroot.net/results/f49/f4914bb3999c8a7a0c0a2afdac5de40fb9058372/ Similar to the existing handling for avr32 and xtensa. Also add it for gstreamer1 for good measure as it was missing there as well. Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-02-25gst-fsl-plugins: add missing librt linking for libgstfsl.Peter Seiderer
Fixes runtime failure of gst-fsl-plugins, e.g. (gst-plugin-scanner:1700): GStreamer-WARNING **: Failed to load plugin '/usr/lib/gstreamer-0.10/libmfw_vpu.so': /usr/lib/libgstfsl-0.10.so.0: undefined symbol: shm_open) when compiled with buildroot/glibc toolchain. See also old buildroot mailing list request [1]. [1] http://lists.busybox.net/pipermail/buildroot/2013-June/073910.html Signed-off-by: Peter Seiderer <ps.report@gmx.net> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-02-24packages: missing propagation of !mmu from pangoThomas Petazzoni
A number of packages that select Pango (which depends on BR2_USE_MMU) forget to also depends on BR2_USE_MMU. This commit fixes that. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-02-14i.MX: Update versions to match latest Freescale releaseEric Nelson
Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-02-14i.MX: Use FREESCALE_IMX_SITE for Freescale packagesEric Nelson
This patch consolidates the URLs for various Freescale-supplied packages to use FREESCALE_IMX_SITE. Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com> Reviewed-by: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-02-01gstreamer{,1}: use more sensible kconfig namesPeter Korsgaard
The gstreamer / gstreamer1 names are not directly obvious to outsiders, so spell out the fact that they are about the 0.10 and 1.x versions. Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-01-20gst-ffmpeg: fix build for xtensaBaruch Siach
Since commit 6ea49a23df3 (gst-ffmpeg: Use internal libav instead of external ffmpeg) gst-ffmpge uses its internal libav. This requires the same fix for xtensa like ffmpeg got in commit 4ec35e76b8a3 (ffmpeg: fix build for xtensa). Fixes http://autobuild.buildroot.net/results/08a/08a27891fd5336250f00e611a15ea45505985f67/. Signed-off-by: Baruch Siach <baruch@tkos.co.il> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-01-16gst-ffmpeg: Use internal libav instead of external ffmpegBernd Kuhls
External ffmpeg 1.2.4 is incompatible, gst-ffmpeg suggests to always use internal libav. Adding one patch: Fixes compiling with gcc-4.7: gst-ffmpeg-0.10.13_gcc47.patch (taken from Slackware) Fixes http://autobuild.buildroot.net/results/ab8/ab8ec4904020ceb848a1e50f1865f594f46b8295/ http://autobuild.buildroot.net/results/f0a/f0a420015a92ebb8868c41c0dbf82cf27b2bdd0f/ Signed-off-by: Bernd Kuhls <berndkuhls@hotmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-01-04package: remove the empty trailing line(s)Jerzy Grzegorek
Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-12-31gstreamer: fix xtensa configureBaruch Siach
Disable unaligned access to avoid configure run test. Fixes http://autobuild.buildroot.net/results/a0c/a0cca019b0b2f33b6c2be17e5a44a807bbb4dac1/. Signed-off-by: Baruch Siach <baruch@tkos.co.il> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2013-12-19gst-plugins-good: fix typo BR2_TOOLCHAIN_HAS_THREADThomas De Schampheleire
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-12-19gstreamer packages: factorize dependency on gstreamerThomas De Schampheleire
Proposed-by: Arnout Vandecappelle <arnout@mind.be> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-12-15Config.in files: unification of comments about dependency on Linux kernelThomas De Schampheleire
This patch lines up the comments of packages that need a Linux kernel to be built by buildroot, to the format: foo needs a Linux kernel to be built Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-12-06packages: remove uninstall commandsThomas De Schampheleire
Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-11-22libglib2: needs MMU supportThomas De Schampheleire
Fixes http://autobuild.buildroot.net/results/2e0/2e032c6e44e10f2912935715741c3680a19b9b51/ Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-11-10Config.in files: add missing dependencies to toolchain option commentsThomas De Schampheleire
When a package A depends on config option B and toolchain option C, then the comment that is given when C is not fulfilled should also depend on B. For example: config BR2_PACKAGE_A depends on BR2_B depends on BR2_LARGEFILE depends on BR2_WCHAR comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR This comment should actually be: comment "A needs a toolchain w/ largefile, wchar" depends on BR2_B depends on !BR2_LARGEFILE || !BR2_WCHAR or if possible (typically when B is a package config option declared in that same Config.in file): if BR2_B comment "A needs a toolchain w/ largefile, wchar" depends on !BR2_LARGEFILE || !BR2_WCHAR [other config options depending on B] endif Otherwise, the comment would be visible even though the other dependencies are not met. This patch adds such missing dependencies, and changes existing such dependencies from depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC to depends on BR2_BASE_DEP depends on !BR2_TOOLCHAIN_USES_GLIBC so that (positive) base dependencies are separate from the (negative) toolchain dependencies. This strategy makes it easier to write such comments (because one can simply copy the base dependency from the actual package config option), but also avoids complex and long boolean expressions. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> (untested) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-11-01Config.in files: add/update comments on (e)glibc dependenciesThomas De Schampheleire
This patch adds missing comments about (e)glibc dependencies and updates the text of existing comments. Additionally, it splits dependency expressions for the touched packages from depends on BR2_BASE_DEP && !BR2_TOOLCHAIN_USES_GLIBC to depends on BR2_BASE_DEP depends on !BR2_TOOLCHAIN_USES_GLIBC so that (positive) base dependencies are separate from the (negative) toolchain dependencies. This strategy makes it easier to write such comments (because one can simply copy the base dependency from the actual package config option), but also avoids complex and long boolean expressions. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
2013-10-14Config.in files: unify comments of toolchain option dependenciesThomas De Schampheleire
This patch lines up the comments in Config.in files that clarify which toolchain options the package depends on. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-10-06package: remove the default value of the $(PKG)_SOURCE variableJerzy Grzegorek
Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net> Acked-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com) Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2013-10-04gstreamer: fix bison bump build failureGustavo Zacarias
It's due to deprecations in bison 3.0+, fixes: http://autobuild.buildroot.net/results/df4/df473cb34c9914b2c3d3d8ae344cbf7c19255468/ Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>